Source aCis Project rev.270

Changeset 261

Knownlists cleanup, Treasure chests, Valakas & Baium fixes, misc

Knownlists cleanup
- drop of getKnownSummons system and associated map (unused stuff).
- better use of inheritance, use of protected key instead of private in order to use variables instead of getters (slight performance boost).
- maps are now directly initialized, which mean RAM usage is more important at startup, but one check is dropped on a overused command, and we get ride of any null case (it can be only empty).
- addition of getKnownNpcs() method, move getKnownSiegeGuards() from L2Door to ObjectKnownList.
- drop all null checks from knownlists. It is explained because getKnownXXX checks "if obj instanceof XXX", which means if it is instanceof XXX, it can't be null.
- getKnownXXX return a Collection, not a Map anymore. For Map, use getKnownXXXMap() (used only in getKnownRelationsMap() and getKnownPlayersMap()).
- drop of MOVE_BASED_KNOWNLIST config and system (unused).
- change all getKnownXXX in order to use the most appropriate choice (avoid cast from L2Object to L2Character, for example).

Treasure chests
- unlock skillhandler has been fully reworked (drop of SocialAction, fix aggro on mimic, etc).
- the trap system has been dropped, as chests use only one type of skill (suicide type one).
- drop of _mustGiveExpSp and associated getter/setter/use. doDie(null) means the monster doesn't give any xp/sp.

Valakas and Baium fixes
- use their NPC knownlists rather than zone knownlists (to avoid out of range issues).
- addition of a random number in order they pick another target after a while.
- valakas only : don't bother with L2Pet anymore && raise by 2 the radius to count ppl for AoE skills behavior.

Misc
- cleanup some doDie methods (drop of a useless broadcastStatusUpdate(), cleanup in L2Npc (fusion stuff + try catch) and L2Character (fusion + pointless PhoenixBlessed stuff).
- more uses of getFirstEffect() method instead of retrieving all effects and looping on them.
- mobs who die by suicide skill don't reward any XP/SP.
- drop 2 logs concerning "invalid clan id for player xxx" and "unknown skill for summon: xxx".
- MoS AI see if you're a male/female in order to use "Brother or "Sister". Yes, I know. But it's like that.
- water flag is stored back in L2PcInstance.


Changeset 262

Cursed weapons, misc

Cursed weapons - ty hasha for critical error support nunu, was making me crazy
- fix the visual glitch on inventory when you lose a CW.
- drop of duration lose when you kill a player (couldn't verify with NCSOFT patch notes / forum if such feature exists).
- added overall expiration timer of 72h.
- added hungry expiration timer (24h by default) - must kill someone before the 24h are gone else CW disappears.
- added random victims number per stage (between 5 and 15 with default configs).
- when a player drops the CW, resets the stage to 1. The overall timer is kept, and hungry timer is dropped too.
- decreased the drop chance from 1/10000 to 1/1000000.
- no issue anymore when you assimilate a CW with another CW.
- //cw_info is updated in order to get a complete control of stats.
- infos are saved on DB every minute (mostly for timers). Drop the save on Shutdown.
- activation of //reload cw.
- you can't rank up a CW on a summon anymore.
- The 2 active skills are now linked to items directly.

Misc
- add missing Manor priviledges on L2CastleChamberlain.
- debug L2CastleChamberlain about clan members who couldn't access it, even with priviledges.
- fix 2 possible NPEs with getCurrentFolk(). Probably more to add.
- drop ExtractableItems.java itemhandler (unused, ty sahar).
- fix lethal chance of 3 skills (it's a base 1000, not 100) : Banish Undead, Turn Undead, Banish Seraph.
- drop of FORCE_INVENTORY_UPDATE config (unused + buggy + fat code).
- fix a NoSuchElementException on L2WeddingManager.

Changeset 263

Dimensional Rift, misc

Dimensional Rift
- Fix some methods leading to broken "start".
- Revert some start checks in order items check and consumption aren't made in same time (check first, then consume).
- XMLize and merge loading process of "dimensional_rift.sql" (rooms infos) with "dimensional_rift.xml" (rooms spawns infos).
- Fix room 7 of Hero rift (cf rev 178).
- all FastList are changed for List.
- Add an HTM for "rift is full" behavior, drop the "cheater" htm (return directly).

Misc
- Fix a MysqlDataTruncation with macros (255 chars max).
- Remove a check about CW and pets (the used sysstring was wrong also...).

Changeset 264

Misc
- fix a MysqlDataTruncation on shortcut save (max number by page = 10).
- fix previous CW refactor about max stage level.
- cleanup AdminMammon adminhandler.
- add a variant of "admin_list_spawns" named "admin_list_positions", and move it from AdminMammon to AdminSpawn.
- fix mass summon cubics radius for party members.
- fix CrestCache getCrest() (couldn't return null and so issue to clean invalid crests), ty Java-Man.
- cleanup of getTargetList() method. Multiple improvements (FastList > ArrayList, variables initilialization in the shortest scope).
- fix SSBoost usage for BLOW skillhandler.
- cleanup a couple of skillhandlers, in order they use the inheritated list of L2Object rather than calculating a new one.
- fix harvest system + harvest messages aswell.

Changeset 265

Misc
- fix GoldenRam issue.
- fix 2 CW issues (when player drops it).
- correct implementation of shift click, with use of inheritance.
- addition of item shift+click possibility for GMs, HTMlize static object shift+click for GMs.
- fix mercenary tickets pickup (probably, couldn't test as we're in wrong 7signs period), optimize item pickup check aswell.
- move caches section upper than clan section, in order to avoid clans crests being deleted at server startup (as crest cache isn't yet initialized).


Changeset 266

L2OFF droplist, misc

Droplist
- parse L2OFF IL droplist. Go from 26881 to 29767 drops. A big ty to dEvilKinG for that work.
- Core side goes from SQL to XML aswell.

Misc
- fix AQ minions paralyze/silence.
- DatapackRoot config is dropped. I don't find any point to put your DP in another folder, added to that the config is probably bad integrated.
- fix a possible NPE if a RB got suicide skill (happen only when sahar got events ideas).

Changeset 267

HtmCache/NpcHtmlMessage cleanup by Hasha.

Changeset 268

Hasha quest engine cleanup.

Quest
- QuestEventType class to its own class.
- sorted all methods by groups (I suggest to create "//INFO: this is some info for text below" tag for the GS,DP pack projects).
- dropped "character_quest_global_data" table, since it only written in 2 quests (never read).
- removed "class_index" column in "character_quests" (never used).
- global quest variables methods unified for simpler usage.
- dropped some method concerning quest load/close (not used).
- added isRealQuest() method to separate scripts from live quest. That means every live quest needs to have _Id > 0.
- method changes :
- player handling filters player with desired quest state or condition :
- getRandomPartyMember() now includes a range check.
- checkPlayerCondition/State() last hit drops.
- getPartyMembers/State() full party last hit (can be used directly in FOR loop).
- getRandomPartyMember/State() party random.
- getClanLeaderQuestState() concerned range check set to npc, not player anymore.
- spawn, timer handling :
- cleaned up, unified usage for these methods.
- dropped methods with same name and different parameters (now you have one method and fill all necessary params in it -> clear usage).

State
- added in QuestState class.
- changed quest state storage type in "character_quests" table from String to Byte.

QuestState
- these methods created/modified
- item handling (usable during quest) :
- giveItems() simply remove specified amount of items.
- takeItems() simply remove specified amount of items.
- drop handling (usable for quest item drop) :
- in order to support rate of dropping quest items, added drop type parameter to these methods (see javadoc tag).
- dropItemsAlways() amount is affected by Config.QUEST_RATE_DROP.
- dropItems() amount/chance are affected by dropType param and Config.QUEST_RATE_DROP .
- reward hanling (usable for quest rewards) :
- rewardItems() rewards player with items (config applied).
- rewardExpAndSp() rewards player with exp, sp (config applied).
- removed spawn and timer methods from this class, everything is handled in Quest directly (it wasn't necessary to use QuestState for it).

General
- fixed onTalk bug, where player could start quest from another NPC, than registered

---- IMPORTANT ----

For existing database, use attached sql command :

USE acis;
SET NAMES cp1250;

DROP TABLE IF EXISTS character_quest_global_data;

ALTER TABLE character_quests DROP COLUMN class_index;

UPDATE character_quests SET value='1' WHERE var='' AND value='Start';
UPDATE character_quests SET value='2' WHERE var='' AND value='Started';
UPDATE character_quests SET value='3' WHERE var='' AND value='Completed';

---- EDIT TRYSKELL ----

Those are additions to original Hasha's notes'n'patch.

- added a check for custom scripts to avoid the reload state when they load, as they all use the same id.
- fix giveItems() behavior (was completely buggy, Hasha...).
- add few final keywords (cause I like them).
- ArrayList initializations are changed for primitive List, it's a bad use to use an "evolved form", as it limits possibilities. In the same spirit we could use directly "HashMap = new HashMap" for maps, but we don't.

Changeset 269
Quests, misc

Quests
- addition of Q337.
- fix critical issues appearing in last revision, and impacting 80+ quests (boolean stuff, custom scripts && objectId).
- drop the max level on all quests, and harmonize all HTMs about "you need level X in order to make the quest". Remove hardcoded versions and add HTMs for Q042/Q043/Q044.
- fix Q656 min level.
- fix Q341 repeatable state.
- addition of a couple of missing "st.exitQuest(true);" (Q338, Q354, Q356)
- Q371 party system is now ok.
- rework Q027, Q028, Q029, Q030 STATE_CREATED.
- use of Race model rather than ordinal, it's easier to read/debug.
- complete rework of Alliance/Clan java. HTMs are harmonized following 7Signs ones. Probably more to do (like moving all events on scripts directly).
- custom scripts (-1) are out of queststate checks when not involved by db edition or variables save/load/checks.
- rework endQuest(), only one db query is made to drop all (on L2J, one db query per variable).
- L2PcInstance : _quests FastMap is changed for a FastList, _notifyQuestOfDeathList is directly initialized (avoid synchro shit and null checks).
- drop missing SQL stuff about character_quest_global_data.

Misc
- rework regen skill in order Valakas doesn't cast it at all, but got directly the effect. Add a random timer aswell.
- drop slow effects on 4 bleed augment (postIL behavior).
- fix "Heart of Pa'agrio" radius effect and icon (more skills to come later, I know SweeTs I KNOW).
- fix all silence times and chances (basically 80% 30sec for one target, 40% 30sec for aoe).

Changeset 270
Quests (Sailren questline), misc

Quests
- addition of Q123, Q125, Q126, Q127, Q367, Q413, Q641. Ty to sharers!
- fix rewards for Q631.
- rework rewards Map to use int[][] instead (Q631, Q640, Q642, Q644, Q645, Q646).
- checkPlayerState() and checkPlayerCondition return the QuestState (avoid to create anew a QuestState). Not affecting party quests.
- fix Q241 NPEs.

Misc
- addition of fail enchant messages, ty dEvilKing.
- fix stopWaterTask(), ty xblx.
- drop a double message when you use TP, ty sahar for report.
- [L2J 5584] calculatePledgeClass() is now static.
- [L2J 5584] fix Noblesse/Hero status icon for clanless characters.
- [L2J 5584] L2ClanMember uses a ResultSet / the player instance directly. Can't create a L2ClanMember if clan is null.
- one of stopMove() parameters is dropped. Avoid to send x2 broadcastPacket(new StopMove) on L2TamedBeastInstance. Add a stopMove on /unstuck.
- addition of 4 missing spawns for Q125/Q126.
- addition of missing HTMs for npcid 32109 (needed for Q126/Q641), implementation in GrandBossTeleporters script with retail HTMs.
- fixed numerous retail typos : Siren > Sailren, Elkrokhi > Elroki, ax > axe.